fix(SDK-1275): match legacy's date bounds for off-cycle pay periods - #2702
Open
krisxcrash wants to merge 3 commits into
Open
fix(SDK-1275): match legacy's date bounds for off-cycle pay periods#2702krisxcrash wants to merge 3 commits into
krisxcrash wants to merge 3 commits into
Conversation
Only the check-only checkbox had description text; the Payment date field itself had none. Legacy shows "Enter the date you'd like your employees to receive payment." underneath it. Add the same via the existing description prop, matching checkOnlyDescription's pattern.
Legacy allows a rolling 1-year-past to 1-year-future window on start date, end date, and payment date, identically for Bonus and Correction (app/views/off_cycle_payrolls/_pay_period.erb; Records::Payroll's GENERAL_OFF_CYCLE_REASONS comment: "allow an arbitrary check date"). The SDK instead blocked any future start date, but only for Correction, with no legacy counterpart. Drop that rule and wire the real ±1-year bound onto all three date pickers instead.
krisxcrash
marked this pull request as ready for review
September 3, 2026 23:19
Base automatically changed from
kw/fix/sdk-1273-payment-date-helper-text
to
main
September 4, 2026 22:36
serikjensen
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #2701 -- touches the same lines in
OffCyclePayPeriodDateFormPresentation.tsx, please land that one first. This diff will narrow to just this change once it does.app/views/off_cycle_payrolls/_pay_period.erbin gws-flows;Records::Payroll'sGENERAL_OFF_CYCLE_REASONScomment: "allow an arbitrary check date")Test plan
maxDate/minPayPeriodDatecomputation