fix(SDK-1266): guard against a partial date range reaching Apply - #2717
Open
krisxcrash wants to merge 1 commit into
Open
fix(SDK-1266): guard against a partial date range reaching Apply#2717krisxcrash wants to merge 1 commit into
krisxcrash wants to merge 1 commit into
Conversation
DateRangeFilter treated draftRange as appliable whenever the object was truthy, without checking that both start and end were present. The default DateRangePicker can never emit a one-sided range, but any other DateRangePicker adapter (including a host's custom implementation) could, and a one-sided range silently produced an asymmetric API request that surfaced as a generic, confusing error. A malformed range now collapses to "no selection" instead.
krisxcrash
marked this pull request as ready for review
September 4, 2026 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateRangeFilter.handleApply()treateddraftRangeas valid whenever the object was truthy, without checking thatstartandendwere both present.DateRangePickercan never emit a one-sided range (react-aria withholdsonChangeuntil both sides are complete), so this gap was invisible there — butDateRangeFilteraccepts anyDateRangePickeradapter, and a non-conforming one could emit a partial range that would sail through togetApiDateParams(), building an asymmetric request that surfaced as a generic, confusing error.handleRangeChangenow coerces any range missing either side tonull, so Apply falls through to the existing clean-reset path instead.Jira: SDK-1266
Test plan
DateRangeFilter.test.tsxpasses (7/7)eslint/tsc --noEmitclean