fix(SDK-1261): hide the visible Status column header label - #2719
Open
krisxcrash wants to merge 1 commit into
Open
fix(SDK-1261): hide the visible Status column header label#2719krisxcrash wants to merge 1 commit into
krisxcrash wants to merge 1 commit into
Conversation
The Status column reads empty for unprocessed payrolls outside the 14-day due-soon window -- an intentional gap in the status rule set, not something this change addresses. Per the reported fix, the visible "Status" header label is removed while keeping the column and cell logic intact, using the same VisuallyHidden pattern DataTable already uses for its own select/actions column headers so the column keeps an accessible name.
krisxcrash
marked this pull request as ready for review
September 4, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculatedAtand a deadline either absent or more than 14 days out — an intentional gap in the status rule set (there's a passing test asserting 0 badges for exactly this case), not addressed here.VisuallyHidden, the same patternDataTablealready uses for its own built-in select/actions column headers, so the column keeps an accessible name for screen readers.Jira: SDK-1261
Test plan
PayrollList.test.tsx/PayrollListPresentation.test.tsxpass (31/31)eslint/tsc --noEmitclean