Preserve prompt padding masks during conditioning - #2
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SimWAM prompt-conditioning path currently replaces the tokenizer validity
mask with an all-ones mask after zeroing padded embeddings. As a result,
padded rows can still participate in cross-attention (for example after a
projection bias or in attention implementations that consume the mask).
This change preserves the tokenizer mask and defensively zeros invalid rows
with an out-of-place operation that also works for non-contiguous encoder
outputs.
Validation
pytest -q tests/test_prompt_mask.py(2 passed)python -m compileall -q src/simwam testsgit diff --checkThe regression tests cover both the returned prompt mask/embeddings and the
invariance of cross-attention to changes in padded context rows.