feat(evi): capture cross-channel feedback in a Postgres store - #563
Open
evlogai[bot] wants to merge 3 commits into
Open
feat(evi): capture cross-channel feedback in a Postgres store#563evlogai[bot] wants to merge 3 commits into
evlogai[bot] wants to merge 3 commits into
Conversation
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The capture side of EVL-253: cross-channel feedback stored in the Postgres store provisioned in #560, ready to feed the weekly self-review and evals (consumption is a separate issue).
feedbacktable (channel,source,verdict,author,text,messageRef,threadRef,sessionRef,createdAt) with a generated migration.feedback__recordtool any non-autonomous session can call, so a person in any conversation can say "this answer was wrong because X" and have it stored. Gated onisDbConfigured(); without the DB it degrades to a clear unavailable error.captureReactioninagent/lib/feedback.ts, which maps an emoji to a verdict and records it (or no-ops for non-thumbs and removals):onDataWebhook(CommentReaction create). Fires only if the Linear webhook subscription includes theCommentReactiontype; deployment-side setting, silent no-op otherwise.bot.onReaction). The repo's eve patch (patches/eve@0.31.3.patch) now exposes anonReactionoption onphotonIMessageChannel;agent/channels/photon.tswires it tocaptureReaction. The patch is the existing mechanism this repo already uses for the photon channel.feedback__statstool, admin-only (canAccessAdminTools), returning totals, positive/negative split, reaction vs written counts, per-channel counts, and the recent written negative feedback with reasons.Checks
lint: clean on the changed files (theeviapp has no standalone lint script).test: 99 passed, 16 files (4 new feedback tests on top of the previous run).typecheck: green. The earlierdistinctIdFieldfailure inagent/hooks/evlog.tswas a sandbox install-linking artifact; a cleanpnpm installresolves it and main typechecks.eve build: succeeds with the patched channel.Notes
apps/eviplus the existingpatches/eve@0.31.3.patch, so no changeset is needed. The lockfile diff is only the eve patch hash (13 lines).reactionwebhook events (its parser coversissue_comment,pull_request_review_comment,issues,pull_request,check_suite,check_run,workflow_run). Capturing them needs (a) the GitHub App webhook subscription to includereactionevents and (b) an eve github-channel extension mirroring the photon one: parsereactionevents and expose anonReactionoption. I did not ship that blind: it depends on the subscription existing and I cannot exercise a GitHub reaction webhook from the sandbox. Happy to do it once the subscription is confirmed or as a follow-up.db:migrateruns at deploy.