Add a comments sidebar & associate comments to specific objects - #4923
Add a comments sidebar & associate comments to specific objects#4923wes-otf wants to merge 11 commits into
Conversation
| {% if activities.count > 1 or activities.count == 1 and not preview_activity %} | ||
| <details class="collapse collapse-arrow group" id="statusDetail" {% if open %}open{% endif %}> | ||
| <summary class="collapse-title"> | ||
| <h2 class="card-title">{% blocktrans with activity_count=activities.count %}Status & Activity <span class="font-normal text-base-content/70">({{ activity_count }})</span>{% endblocktrans %}</h2> |
There was a problem hiding this comment.
If possible, avoid tags in translated strings.
There was a problem hiding this comment.
what do you think makes the most sense for this? for RTL languages I figured the ability to put the count on the left would be ideal, but can also include the variable in the translation & just remove the formatting, just thought it was slick.
| {% if not object.is_archive or object.projects.exists %} | ||
| <h2 class="sr-only">{% trans "Add communication" %}</h2> | ||
| <div class="pb-6 mb-4 w-full border-b border-base-300"> | ||
| <div class="pb-6 w-full border-b border-base-300"> |
There was a problem hiding this comment.
this was causing a gap between the start of the border & the timeline line which is why I removed it here
0b181fd to
fff21db
Compare
|
@wes-otf I rebased this on top of main. Hopefully it is a clean rebase. Will do a review as well. |
fff21db to
961afbb
Compare
…conditional field inclusion with `CommentForm`, small timeline formatting fixes
961afbb to
ad71718
Compare
|
I took the liberty to add some translation fixes to this PR. |
| """ | ||
| language = get_language() or settings.LANGUAGE_CODE | ||
| if not language.lower().startswith("en"): | ||
| return text |
There was a problem hiding this comment.
This was a great solution for this @frjo - thanks for adding it!
|
Looks great to me! Thanks for adding those! |
Closes #4871. Adds the ability to comment on objects like Project Forms, SOWs, Reports & Invoices via a "mini" comment form in the detail view sidebar for said objects.
This PR also covers a few related yet adjacent things:
max-w-[60rem]→max-w-240)TODO:
Make status updates to PF/SOW reactive like they are for InvoicesAssociate status updates (ie. approvals) to the ProjectFormPointer instead of the project so they show in the Status & Activity sectionTest Steps
Confirm that...