Add an AWS deployment planning skill for Prebid Server Go - #1166
Open
ChristianPavilonis wants to merge 4 commits into
Open
ChristianPavilonis wants to merge 4 commits into
ChristianPavilonis wants to merge 4 commits into
Conversation
Gather deployment requirements before choosing AWS services and generating Terraform or runtime files. Keep cloud execution behind separate approval and document safe testing, state ownership, and credential handling. Refs #1163
ChristianPavilonis
marked this pull request as ready for review
September 15, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts pbs inspect,check,secrets set, andstatusinside the existing CLI, with redacted discovery, local configuration checks, guarded Secrets Manager writes, and EC2 infrastructure status.deploy/sandbox is excluded from this PR.Current blocker after integrating the remote branch
Not ready to merge. The remote branch had advanced to
7d919d66, which merged currentmain. That work is preserved by local merge commit1dfd8c83; no force push or history replacement was used.The upstream schema now keeps server-side bidder routing under
auction.providersandauction.bidders, whilePrebidIntegrationConfigis browser-only. The currentinspectimplementation and skill discovery guidance still target the earlier server-side fields underintegrations.prebidand need a compatibility update.Post-merge
./scripts/test-cli.shfails to compile atcrates/trusted-server-cli/src/commands/pbs/inspect.rs:282withE0609:PrebidIntegrationConfigno longer has abiddersfield. Removing the parity assertion alone would hide the discovery mismatch. Adapt discovery, fixtures, and guidance to the new schema, then rerun tests and lint before treating the prototype as usable with current configuration.The successful verification below was performed before integrating that remote merge. It is not a green result for the current PR head.
Changes
.claude/skills/planning-prebid-aws/SKILL.mdts pbs.crates/trusted-server-cli/src/commands/pbs/Cargo.toml, andCargo.lockts config,ts deploy, andts prebid bundlebehavior stays unchanged.crates/trusted-server-cli/tests/pbs_cli.rsand module testscrates/trusted-server-cli/README.mdandexamples/pbs/.tool-versionsOperator commands
ts pbs inspect --config <file>ts pbs check --deployment <file>ts pbs secrets set <bidder> --deployment <file> --region <region>ts pbs status --deployment <file>Secret values stay out of process arguments and reports. AWS request payloads use owner-only temporary files on Unix, removed on normal success/error paths. Raw AWS stderr is withheld. Abrupt termination can leave temporary files; use protected temporary storage. Windows ACL behavior has not been validated.
Review decision and remaining scope
Please review whether PBS management belongs permanently under
ts pbsin the existing CLI. This is an experiment, not a decision to create a separate crate, binary, or per-deployment wrapper.The current descriptor supports
ec2-composeonly. The planning skill can still recommend ECS or another approved architecture, but its CLI integration must be implemented separately. There are no placeholderdeployorrollbacksubcommands.Versioned runtime delivery needs an approved ownership transition where Terraform user data currently installs runtime files. This PR does not provision infrastructure, install a secret loader, replace containers, adopt sandbox state, activate bidders, or change caller traffic. All committed deployment examples use fictional targets and are not deployable configurations.
Closes
Closes #1163
Test plan
./scripts/test-cli.shis blocked by the schema compatibility compile error above.auction.*configuration, then rerun the complete native CLI checks.Completed before integrating the remote branch
./scripts/test-cli.sh: 110 tests passed on Linux, including five process-level PBS tests using a fakeawsexecutable.cargo fmt --all -- --check.cargo clippy --package trusted-server-cli --all-targets --target x86_64-unknown-linux-gnu -- -D warnings.npx --yes prettier@3.4.2 --check --config docs/.prettierrc '.claude/skills/planning-prebid-aws/**/*.md' crates/trusted-server-cli/README.md 'crates/trusted-server-cli/examples/pbs/*.{yaml,json}'.cargo run_cli_linux pbs inspect --config trusted-server.example.toml --jsonandcargo run_cli_linux pbs check --deployment crates/trusted-server-cli/examples/pbs/deployment.yaml --json.deploy/is excluded.Deferred evidence
Checklist
disable-model-invocation: true.unwrap()calls..tool-versionsis included; the generateddeploy/directory remains local and untracked.