[FIX] #48017 UI: skip isClientSideValueOk() for null - #11953
Merged
thibsy merged 1 commit intoAug 20, 2026
Merged
Conversation
iszmais
requested changes
Aug 18, 2026
iszmais
left a comment
iszmais
left a comment
Contributor
There was a problem hiding this comment.
This need to check the $value, not the $input.
Otherwise this works for me.
thibsy
force-pushed
the
fix/11/ui-input-group-with-value
branch
from
August 18, 2026 14:36
178a9fa to
236f432
Compare
iszmais
self-requested a review
August 18, 2026 14:37
iszmais
approved these changes
Aug 18, 2026
…ning#11953) This ensures that `withValue()` can be called on nested sub inputs without calling respective `isClientSideValueOk()` methods. Unfortunately this couples the `isClientSideValueOk()` internals to `withValue()` internals, which is suboptimal. We should improve how inputs handle `null` (maybe using `Refinery\Transformation`) and revisit this at a later point.
thibsy
force-pushed
the
fix/11/ui-input-group-with-value
branch
from
August 20, 2026 09:22
236f432 to
a380dac
Compare
Contributor
Author
|
This should be fine for the time being, I could not think of any unwanted side-effect and I am willing to find out the hard way =). I will integrate this now, thx @iszmais for checking with DataCollection. |
thibsy
added a commit
that referenced
this pull request
Aug 20, 2026
This ensures that `withValue()` can be called on nested sub inputs without calling respective `isClientSideValueOk()` methods. Unfortunately this couples the `isClientSideValueOk()` internals to `withValue()` internals, which is suboptimal. We should improve how inputs handle `null` (maybe using `Refinery\Transformation`) and revisit this at a later point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @iszmais,
This should probably address https://mantis.ilias.de/view.php?id=48017, can you verify?
I will think about possible side-effects in the meantime.
Thx and kind regards,
@thibsy