Header read-only - #21
Open
Ghesselink wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only_headerlimits what is returned, not what is read: currentlyparse()reads the whole file and the comment-stripping regex makes a second full copy, before the header (a few hundred bytes, always at the top per ISO 10303-21) is sliced out.This PR stops reading after the
ENDSEC;that closes the HEADER section (64 KiB chunks).Some tests: peak RSS of an
only_header=Trueparse:Also slightly faster on large files, but it was never a time cuonsumer to begin with (0.37 s → 0.19 s at 130 MB).
Testing:
test_parser.pytested with VS testfiles from the header validation, outcome is the same. g