feat(cpu): add SiLU implementation - #859
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator<Silu, Device::Type::kCpu>for contiguous and strided CPU tensors.Motivation
The torch-infini PrivateUse1 plugin needs InfiniOps to expose
Siluin CPU-only builds before it can register standardaten::siluwhile retaining its no-accelerator fallback. Without a CPU specialization, the generated public operator header omitsSilubecause no active CPU implementation exists. Adding the native CPU path makes the generated call surface available and keeps CPU fallback behavior consistent with accelerator builds.No issue is linked to this prerequisite change.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
The operator is intentionally excluded from the minimal smoke allowlist because it reuses the existing elementwise execution path. Therefore,
INFINI_OPS_SMOKE_BUILD=ONwould not compile or exercise this implementation. The affected CPU path was instead validated with a full CPU-only wheel build, followed by the unchanged smoke suite and the complete SiLU test module.The exact commit
023f7fc15736464947281f0c638e6a319c7bdaa9was built inaccelerator-dev/nvidia:latestagainst a CPU-only install of InfiniRT95c70080f9551e61241110497d163dfcdf9dc7e7.The smoke collection contained no
tests/test_silu.pycases. The modified C++ file also passed clang-format.Test Results on Supported Platforms
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A. This correctness-only PR does not claim a performance change.
Notes for Reviewers
Please focus on the strided indexing and the promoted float32 computation used for float16 and bfloat16 inputs. This PR intentionally does not change the smoke allowlist. It is a prerequisite for registering standard
aten::siluin torch-infini without breaking CPU-only builds or CPU fallback execution.