Fix 404 on localized "Join us on Slack" menu links - #1220
Merged
Conversation
The Slack join links in the non-English navigation menus pointed at the relative path /slack. The menu renders every relative link through absLangURL, which prepends the active language prefix, so in each non-English locale the link resolved to /<lang>/slack (e.g. /pt-br/slack). The Slack join page exists only once at the site root (/slack, a redirect to the Slack invite), so every localized variant returned a 404. Point the Slack menu links in all eight non-English menus at the absolute https://innersourcecommons.org/slack. absLangURL passes absolute URLs through unchanged, so each locale now links to the working join page while the invite link stays single-sourced in the English /slack redirect. English is unaffected (it has no language prefix). Reported in the community Slack for the pt-br locale; the same 404 affected de, es, fr, it, ja, ru, and zh. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLosAREuF2wPWvGZfn66tg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Join us on Slack" navigation link (and the "Join our Chat on Slack" link under Start Here) returned a 404 in every non-English locale.
Why
The menu links pointed at the relative path
/slack.The nav template renders every relative menu URL through Hugo's
absLangURL, which prepends the active language prefix - so in each non-English locale the link resolved to/<lang>/slack(e.g./pt-br/slack,/de/slack,/ja/slack).The Slack join page exists only once, at the site root (
/slack, a redirect to the Slack invite), so every localized variant 404'd.English was unaffected because it has no language prefix, so its
/slacklink already resolved to the real page.Fix
Point the two Slack menu links at the absolute
https://innersourcecommons.org/slackin all eight non-English menus (de,es,fr,it,ja,pt-br,ru,zh).absLangURLpasses absolute URLs through unchanged, so each locale now links to the working join page, and the invite link stays single-sourced in the English/slackredirect page.English
menus.en.yamlis left as-is.Origin
Reported in the community Slack
#generalby Shingo Oidate for thept-brlocale; verified the same 404 onde,es,fr,it,ja,ru, andzh.🤖 Generated with Claude Code