COMP: Require ITK 6 - #482
Draft
hjmjohnson wants to merge 1 commit into
Draft
Conversation
Every example links ITK::...Module interface targets, which ITK 5.x does not export, so against ITK 5.4 configure fails with one missing-target error per example (346 in all). Requiring ITK 6 stops at the first find_package with a single version error instead. Examples for ITK 5.x now live on the release-5.4 branch.
github-actions
Bot
added
area:Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the minimum ITK to 6. Every example already links
ITK::<Name>Moduleinterface targets, which ITK 5.x does not export.
What ITK 5.x does today, and what this changes
Against ITK 5.4 the build currently fails with one missing-target error per
example — 346 in all — because the namespaced interface targets were introduced
in ITK 6. Requiring ITK 6 stops at the first
find_packagewith a singleversion error instead:
Three examples carried their own older minimums (4.7.0, 5.0.0 twice); they are
raised to 6 for consistency with the top-level requirement.
Where ITK 5.x examples live
The
release-5.4branch was created atb0679d89, the last commit that stillbuilds against ITK 5.x. Verified against ITK 5.4.7: 0 failed targets, 346
executables, 370 of 370 tests passing.