Skip to content

Remove constraint on crypton-x509-system - #6647

Merged
erikd merged 4 commits into
masterfrom
erikd/crypton-x509-system-dep
Aug 10, 2026
Merged

Remove constraint on crypton-x509-system#6647
erikd merged 4 commits into
masterfrom
erikd/crypton-x509-system-dep

Conversation

@erikd

@erikd erikd commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

This constraint was a blocker on upgrading to crypton >= 1.1 and the migration from the memory package to the ram package.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@erikd
erikd requested review from a team as code owners August 10, 2026 00:55
@erikd
erikd force-pushed the erikd/crypton-x509-system-dep branch 4 times, most recently from 2ae93a3 to 38cd56d Compare August 10, 2026 04:40
erikd and others added 2 commits August 10, 2026 15:30
This constraint was a blocker on upgrading to crypton >= 1.1 and
the migration from the memory package to the ram package.

This constraint prevents triggering a bug in haskell.nix. The new
constraint avoids trigger the haskell.nix bug, but also allows
the upgrade of dependencies that repy on this package (ie grapesy).
optparse-applicative-fork 0.19 wraps the usage's brief description in an
align, which shifts the overflow to the right of the command name and
wastes most of the line width. Unwrap the align in the parser
preferences via helpEmbedBriefDesc, restoring the pre-0.19 layout where
the overflow hangs at a two-space indent, and update the golden files.
The only remaining difference from the 0.18 output is trailing
whitespace that 0.19 itself introduces.
@erikd
erikd force-pushed the erikd/crypton-x509-system-dep branch from 38cd56d to 1eae0fa Compare August 10, 2026 05:30
Comment thread cabal.project
@erikd
erikd added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 10, 2026
@erikd
erikd added this pull request to the merge queue Aug 10, 2026
Merged via the queue into master with commit f335785 Aug 10, 2026
29 checks passed
@erikd
erikd deleted the erikd/crypton-x509-system-dep branch August 10, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants