Accept SQL Server CREATE TABLE trailing commas with shared element parsing - #2603
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Conversation
minleejae
force-pushed
the
fix/sqlserver-create-table-trailing-comma
branch
from
September 11, 2026 15:49
4eaa336 to
143d161
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server
CREATE TABLE film_text (..., PRIMARY KEY NONCLUSTERED (film_id),)fails on its final comma. Accept one trailing separator withDialect.SQLSERVER, preserving the ordered table elements and normalizing the comma away when rendering SQL.Extract the repeated column/constraint/LIKE choice into one table-element production and remove unused intermediate lists. Other dialects and function return-table definitions retain their existing separator rules.
Validation: full Gradle
check, focused dialect/malformed-input/AST/round-trip regressions, and the updated usage-page Sphinx build passed. The original Sakila schema now parses and round-trips as 70 statements.Refs #1563; this covers the schema separator gap.
Syntax: Microsoft ScriptDom CREATE TABLE grammar.