Support SQL Server boolean SET options with shared statement rendering - #2604
Merged
manticore-projects merged 2 commits intoSep 12, 2026
Merged
manticore-projects merged 2 commits into
manticore-projects merged 2 commits into
Conversation
minleejae
force-pushed
the
feat/sqlserver-set-on-off-options
branch
from
September 11, 2026 18:12
3561776 to
0f85ac2
Compare
minleejae
force-pushed
the
feat/sqlserver-set-on-off-options
branch
from
September 11, 2026 18:21
0f85ac2 to
a338fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server
SET NOCOUNT ONcurrently fails to parse, and grouped options such asSET QUOTED_IDENTIFIER, ANSI_NULLS OFFcannot be represented as ordinary assignments. WithDialect.SQLSERVER,SetStatementnow exposes an ordered, typed option group with one editable ON/OFF value for 23 documented boolean settings. Generic assignments retain their existing representation and expression visitors.The change separates assignment parsing from option parsing and shares SET punctuation between
toString()andSetStatementDeParser. It also adds SQL Server feature validation and table discovery for option groups. Parsing a directive records the setting without changing lexer configuration.Validation: full Gradle
checkpassed (6,567 tests, 0 failures/errors, 25 skipped). Coverage includes all options in both states, grouped options, AST edits, custom expression deparsing, malformed input, statement boundaries, dialect isolation, and existing SET assignments. The updated usage page builds with Sphinx warnings treated as errors.Syntax reference: Microsoft SET statements.