Support SQL Server SET IDENTITY_INSERT with a structured table target - #2605
Merged
manticore-projects merged 1 commit intoSep 12, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
Dialect.SQLSERVER,SET IDENTITY_INSERT [database.][schema.]table ON | OFFnow parses intoSetIdentityInsertStatement. Its editable target reuses the existingTableAST, including qualified and bracket-quoted names, and its ON/OFF value is separate from assignment expressions.Both SQL renderers share statement formatting while table visitors retain context. Table discovery and metadata validation use the structured target, and feature analysis classifies the directive as a session setting. Generic SET assignments and other dialects retain their existing behavior.
Validation: full Gradle
checkpassed (6,563 tests, 0 failures/errors, 25 skipped), covering AST edits, custom visitors/deparsers, metadata, invalid syntax, statement boundaries, and dialect isolation. The original Sakila insert-data script parses and round-trips all 46,326 statements, including 46,273 INSERTs and 26 IDENTITY_INSERT directives. The updated usage page builds with Sphinx warnings treated as errors.Refs #1563. Syntax reference: Microsoft SET IDENTITY_INSERT.