fix: keep CREATE TABLE option tokens in sync with typed options - #2606
Merged
manticore-projects merged 1 commit intoSep 12, 2026
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a typed CREATE TABLE option (for example, changing ENGINE from InnoDB to MyISAM) currently changes
toString()but leaves StatementDeParser using the old value. Derive legacy option tokens from the current typed options instead of retaining a stale copy, and document the typed-token snapshot API.Regression tests cover editing, adding and clearing typed options, plus replacement through the mutable legacy string API.
Validation: Java 17
./gradlew checkpassed, including the full test suite, grammar ambiguity check and static analysis.