fix: traverse and deparse structured table partitions - #2610
Merged
manticore-projects merged 2 commits intoSep 12, 2026
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TablesNamesFinder omits the child table in PostgreSQL ATTACH/DETACH PARTITION and the exchange table in MySQL EXCHANGE PARTITION. Extend shared table-definition traversal to those references and to structured partition keys and PostgreSQL bounds.
Reuse callback-aware rendering for CREATE/ALTER partition keys and bounds, including subpartition keys, while preserving raw MySQL partition-definition values and options. Regression tests cover table discovery, visitor context, custom expression rendering, and unchanged SQL output. MINVALUE/MAXVALUE range markers are preserved and excluded from column-reference traversal.
Validation: Java 17
./gradlew checkpassed, including the full test suite, grammar ambiguity check and static analysis.