feat: preserve ALTER COLUMN default expressions in the AST - #2611
Merged
manticore-projects merged 2 commits intoSep 12, 2026
Merged
manticore-projects merged 2 commits into
manticore-projects merged 2 commits into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER COLUMN SET DEFAULT currently converts the parsed expression into a String, preventing expression traversal and custom deparsing. Retain the Expression, expose it for AST edits, and derive the existing getDefaultValue() text from it. The legacy String constructor remains available and opaque, including nullable calls.
Share ALTER COLUMN action rendering and route ALTER validation through the existing table-definition traversal. Regression tests cover arithmetic, casts, functions, NULL, multiple actions, visitor context, custom deparsing and AST edits.
This change covers ALTER COLUMN SET DEFAULT; CREATE TABLE column defaults retain their existing representation.
Validation: Java 17
./gradlew checkpassed, including the full test suite, grammar ambiguity check and static analysis.