feat: reuse table constraint grammar for PostgreSQL ALTER ADD - #2612
Merged
manticore-projects merged 1 commit intoSep 12, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PostgreSQL mode, ALTER TABLE ADD cannot parse constraint forms already handled by CREATE TABLE, including EXCLUDE, CHECK ... NOT VALID and INITIALLY attributes. Reuse a shared table-constraint production with CREATE/ALTER-specific index-option boundaries, and centralize population of the legacy key accessors from structured indexes.
Regression tests cover named and unnamed constraints, PostgreSQL options and attributes, multiple actions, referenced-table discovery, legacy accessors and invalid tails. Existing non-PostgreSQL ALTER paths remain covered by the full suite.
Validation: Java 17
./gradlew checkpassed, including the full test suite, a zero-choice-conflict grammar check and static analysis.