refactor: share PostgreSQL routine argument grammar - #2613
Merged
manticore-projects merged 1 commit intoSep 12, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Privilege targets and extension members build the same RoutineReference.Argument AST through duplicated grammar. Share mode/name/type parsing while retaining the existing parser entry points and keeping ORDER BY argument boundaries restricted to aggregate-signature contexts.
Tests compare argument ASTs across GRANT and ALTER EXTENSION for modes, qualified and array types, and quoted argument names. They also cover ordered-set aggregates and rejection of aggregate-only syntax in FUNCTION/GRANT contexts.
Validation: Java 17
./gradlew checkpassed, including the full test suite, grammar ambiguity check and static analysis.