Validate every UPDATE assignment through shared UpdateSet traversal - #2623
Merged
manticore-projects merged 1 commit intoSep 13, 2026
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE t SET a = 1, b = ?currently passes validation even when JDBC parameters are forbidden. The validator reads deprecated accessors that expose only the first assignment, so equivalent expressions are checked differently depending on their position.Validate the complete
UpdateSetlist and share assignment traversal with MERGE. Columns and values in every assignment are visited; direct SELECT values use the select validator. This also removes the obsolete first-assignment/select compatibility branch without changing the public UPDATE AST API.Validation: full Java 17 Gradle
checkpasses, including tests, formatting, Checkstyle, PMD, SpotBugs, coverage, and the grammar ambiguity gate. Regression tests cover first/middle/last assignments, tuples, subqueries, independent feature errors across assignments, and the existing MERGE path.