Render DML RETURNING expressions through shared visitor handling - #2624
Merged
manticore-projects merged 1 commit intoSep 13, 2026
Merged
Conversation
minleejae
force-pushed
the
fix/dml-returning-expression-rendering
branch
from
September 12, 2026 13:03
fbdc17f to
78b8177
Compare
Contributor
|
Thank your for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom expression deparser changes the value in
UPDATE t SET a = 7 RETURNING a + 8but leaves the RETURNING expression untouched. INSERT and DELETE have the same inconsistency, preventing consumers from applying one expression transformation across an entire DML statement.Route the three RETURNING clauses through a shared deparser helper that uses the existing callback renderer and select-item visitor. Expressions, aliases, wildcards, and output targets retain the existing AST and SQL layout; nested queries use the configured expression/SELECT visitors.
Validation: full Java 17 Gradle
checkpasses, including tests, formatting, Checkstyle, PMD, SpotBugs, coverage, and the grammar ambiguity gate. Tests verify one callback per expression, nested SELECTs, preserved aliases and OLD/NEW qualifiers, INTO targets, unchanged source ASTs, and round trips.