feat: neuroglancer view (3/6): file-browser multi-select - #424
Draft
allison-truhlar wants to merge 5 commits into
Draft
feat: neuroglancer view (3/6): file-browser multi-select#424allison-truhlar wants to merge 5 commits into
allison-truhlar wants to merge 5 commits into
Conversation
PR 3 adds a leading checkbox column to the file table, so
getByRole('cell').first() is now the checkbox cell. Target the name
cell by its text instead, keeping the assertion robust to column order.
allison-truhlar
force-pushed
the
ngviews-03-multiselect
branch
from
August 7, 2026 19:07
fdda44b to
f58568c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neuroglancer Views — PR 3 of 6 (stacked)
File-browser multi-select, stacked on #423 (PR 2). Frontend-only; the
foundation the floating selection bar and Layer Cart (PR 5) build on.
Base: merge #423 first — this PR targets
ngviews-02-api.What's in this PR
FileBrowserContext— a new, purely additivecheckedPaths: Set<string>(keyed on file
path) plus a derivedcheckedFiles, with actionstoggleChecked/checkPaths/clearChecked. The set resets per-directory(wired into the existing navigation effect).
FileTable— a leading checkbox column: a per-row checkbox and a"Select all" header checkbox, using the house
FgCheckbox.The design (why it's non-breaking)
Two independent selection concepts:
propertiesTarget) —drives the Properties drawer, the Delete/Rename/Permissions/Convert dialogs,
and data-links. Untouched by this PR.
checkedPaths) — will drive PR 5'sselection bar and cart.
Row checkbox clicks
stopPropagation, so ticking a box never disturbs thefocused file / Properties target. Single-select and all 14 of its downstream
consumers are byte-unchanged.
Testing
pixi run test-frontend→ 306 passed (38 files), no regressions.node-check+node-eslint-checkclean for this diff.idempotent union → clear).
FileTabletest renders the real Browse page and asserts the "Select all"header checkbox round-trips unchecked → checked → unchecked through real
context state.
Notes for PR 5
selection) — deferred.
checkedFilesderives from the full listing; select-all uses the rendered(dot-file-filtered)
data. Benign today (checkboxes exist only on renderedrows); flag if the cart should ever include hidden files.
Stack