Boss defeat state toggle support by 虞悖

[zlzhaidou]

This pr added a new feature make player can hold shift and right click to toggle boss or event's defeat state by enable a debug config

TODO: Old One's Army should be splited into three tiers

because Old One's Army have three independent fields
if marks them all as defeat or alive it may allow players to obtain items from beyond the current stage
also not useful for tester to test,buf due to I can't provide sprite and I'm not sure will this be merge so didn't split it yet

Multipalyer

During multiplayer, one player changed a boss's defeat state will broadcast to all players
this feature didn't support singleplayer because it will make the chat history mess

Why 1.4.5

this feature changed param list of Mod.Call,and 1.4.5 will be a nice chance to let every mod adapt this feature.
if release this feature in 1.4.4,other mod have to update to adapt

[JavidPack]

I had assumed you would just add this as an option to the Dictionary<string, object> additional entry data. This way you wouldn't change the Mod.Call API at all. If we maintain compatibility, it'll also work on 1.4.4.

[zlzhaidou]

I had assumed you would just add this as an option to the Dictionary<string, object> additional entry data. This way you wouldn't change the Mod.Call API at all. If we maintain compatibility, it'll also work on 1.4.4.

the reason why I don't want to use this is because I think if nobody know this feature,nobody will use it
and make it as a standard will give affilited mod tester more convenience
just simple add this function if there's no way to let everyone know,about equal to nothing

[JavidPack]

Well, since it's primarily intended just for developers, I think each developer would add it to their mod as they are testing their own mod and need to toggle specific bosses in their mod.

We can consider making it required in 1.4.5 later, but that's far away still and I'm not sure if other mod makers will want to have to update their Calls. It took a lot of time for mods to migrate to the last API changes we made.

I think for now we can add it without breaking changes and see if anyone finds it useful.

[zlzhaidou]

Well, since it's primarily intended just for developers, I think each developer would add it to their mod as they are testing their own mod and need to toggle specific bosses in their mod.

We can consider making it required in 1.4.5 later, but that's far away still and I'm not sure if other mod makers will want to have to update their Calls. It took a lot of time for mods to migrate to the last API changes we made.

I think for now we can add it without breaking changes and see if anyone finds it useful.

that's made sense, I will change this pr tomorrow morning,but I still think make it required in 1.4.5 is better
but the current problem is about the Old One's Army,how to make it adapt this feature?

[zlzhaidou]

and how to let other mod's developer know this feature,I can't think of any way.

[JavidPack]

For Old One's Army, we can think of that later, I'm not sure yet. Sheepish or I would need to think more about it

[zlzhaidou]

already make it be optional,and make Old One's Army do not support this feature now

[zlzhaidou]

So I know how to let other mod's dev know this feature,when this pr merged I will open pr to let other mod support this feature in their mod