fix: Prevent duplicate keydown triggers during IME composition causing duplicate options in Creatable - #6104
Open
phungquan27-05 wants to merge 2 commits into
Open
phungquan27-05 wants to merge 2 commits into
phungquan27-05 wants to merge 2 commits into
Conversation
Ignore keydown events during IME composition to prevent duplicate triggers.
🦋 Changeset detectedLatest commit: e9a6e6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Prevent duplicate keydown triggers during IME composition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where pressing
Enterto confirm IME composition (e.g. Vietnamese, Japanese on macOS) triggersEnteractions twice or prematurely executesprops.onKeyDown.This issue is especially noticeable in
Creatableinputs: when users pressEnterto finish IME composition and create a new option, the component may process the sameEnterevent twice, resulting in two identical options being created instead of one.What changed
Added an early return at the beginning of
onKeyDownwhenevent.nativeEvent.isComposingorevent.keyCode === 229.Prevents composition keydown events from leaking into the
onKeyDowncallback prop and internal select handlers.Ensures that
Enterpressed during IME composition is ignored until composition is fully completed, preventing duplicate option creation and unintended key handling.