debug: also warm-start k̄ for OrthogonalCollocation - #446
Merged
Merged
Conversation
The PR #445 skipped the warm-starting of the `k̄` vector in the decision variable because I though that it was state DERIVATIVE, thus different units than the states. But I was wrong, the `k̄` is the state at the collocation points. There are no reasons to not warm-start this vector anymore.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 28 28
Lines 6656 6656
=======================================
Hits 6451 6451
Misses 205 205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #445 skipped the warm-starting of the$\mathbf{\bar{k}}$ vector in the decision variable because I though that it was state DERIVATIVE, thus different units than the states. But I was wrong, the $\mathbf{\bar{k}}$ is the state at the collocation points.
There are no reasons to not warm-start this vector anymore.