Add hs85 and hs89 problems - #412
Open
arnavk23 wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
===========================================
- Coverage 99.80% 54.63% -45.17%
===========================================
Files 1084 1144 +60
Lines 12319 13639 +1320
===========================================
- Hits 12295 7452 -4843
- Misses 24 6187 +6163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigot
requested changes
Mar 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Hock–Schittkowski problems HS85 and HS89 to the repository, including ADNLPModels + JuMP formulations, metadata entries, and supporting reviewer/workflow documentation.
Changes:
- Implement HS85 and HS89 in
src/ADNLPProblems/andsrc/PureJuMP/ - Add metadata for both problems in
src/Meta/ - Add extraction/workflow/rules docs and a rule-checking script; update
Project.toml
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
src/PureJuMP/hs85.jl |
New JuMP formulation for HS85 (currently has API/export + model-construction issues) |
src/PureJuMP/hs89.jl |
New JuMP formulation for HS89 (currently has API/export + dependency issues) |
src/ADNLPProblems/hs85.jl |
New ADNLP formulation for HS85 (currently double-encodes bounds as constraints) |
src/ADNLPProblems/hs89.jl |
New ADNLP formulation for HS89 |
src/Meta/hs85.jl |
Metadata for HS85 (currently ncon should be updated after removing redundant bound-constraints) |
src/Meta/hs89.jl |
Metadata for HS89 (currently equality/inequality flags are incorrect) |
Project.toml |
Adds StaticArrays dependency (currently unused) |
docs/RULES_hs85_hs89.md |
Adds a checklist doc (currently mismatched with repo conventions: Meta .jl, constructor naming) |
docs/hs85_workflow.ipynb |
Adds an end-to-end workflow notebook (currently calls hs85_jump, which won’t match repo conventions/tests) |
docs/extract_hs89.json |
Adds HS89 extraction artifact (currently inconsistent with provided x0) |
docs/extract_hs85.json |
Adds HS85 extraction artifact |
docs/check_rules.jl |
Adds a basic rule-check script for HS85/HS89 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo @tmigot
Towards #113