Skip to content

init workflow level tests - #98

Merged
dltamayo merged 6 commits into
v2from
workflow-level-tests
Aug 27, 2026
Merged

init workflow level tests#98
dltamayo merged 6 commits into
v2from
workflow-level-tests

Conversation

@dimalvovs

Copy link
Copy Markdown
Collaborator

This pull request refactors the BULKTCR_ANALYSIS workflow in bulktcr_analysis.nf to improve maintainability and clarity by centralizing channel assignments, streamlining report generation, and updating test definitions for better reuse. The changes reduce code duplication, make channel management more explicit, and simplify test configuration.

Workflow refactoring and channel management:

  • Centralized the creation and assignment of all output channels (e.g., ch_sample_csv, ch_tcrdist_files, ch_giana_files, etc.) at the start of the workflow, and used these consistently throughout, replacing scattered conditional assignments. [1] [2]
  • Updated all report generation logic to use the new centralized channels, improving consistency and reducing repeated code for handling outputs at different analysis levels (sample, patient, compare). [1] [2] [3] [4]

Report logic improvements:

  • Refactored the mixing and staging of report files to use the new channels, clarified the inclusion of files for each report type, and improved the logic for handling different analysis levels. [1] [2] [3] [4]

Testing improvements:

  • Updated test configuration in tests/main.nf.test to define the container image and integration modes at the top, and reused these variables in all test cases, reducing duplication and improving maintainability. [1] [2] [3] [4]

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

Unit Test Results

17 tests  ±0   17 ✅ ±0   7m 13s ⏱️ - 1m 0s
 7 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 89cf8a6. ± Comparison against base commit 5adb53c.

♻️ This comment has been updated with latest results.

@dimalvovs
dimalvovs marked this pull request as ready for review August 27, 2026 17:00
@dltamayo dltamayo self-assigned this Aug 27, 2026
@dltamayo
dltamayo self-requested a review August 27, 2026 17:26

@dltamayo dltamayo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dltamayo
dltamayo merged commit 6bd0615 into v2 Aug 27, 2026
3 checks passed
@dimalvovs
dimalvovs deleted the workflow-level-tests branch August 27, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants