loader: Skip layer when interface negotiation fails - #2027
Closed
herlience wants to merge 1 commit into
Closed
Conversation
If a layer's vkNegotiateLoaderLayerInterfaceVersion call fails (e.g. returns VK_ERROR_INITIALIZATION_FAILED), the loader was silently falling back to the legacy vkGetInstanceProcAddr path and still activating the layer, instead of treating the failure as fatal for that layer. Add the missing else branch so a failed negotiation is treated the same as a layer whose library failed to load: log it and skip the layer with continue, rather than adding it to the instance chain. Fixes KhronosGroup#1708
|
Author herlience not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author herlience not on autobuild list. Waiting for curator authorization before starting CI build. |
Contributor
Author
|
Closing this in favor of #2026 which addresses the same root cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a layer's vkNegotiateLoaderLayerInterfaceVersion call fails
(e.g. returns VK_ERROR_INITIALIZATION_FAILED), the loader was
silently falling back to the legacy vkGetInstanceProcAddr path
and still activating the layer, instead of treating the failure
as fatal for that layer.
Add the missing else branch so a failed negotiation is treated
the same as a layer whose library failed to load: log it and
skip the layer with continue, rather than adding it to the
instance chain.
Fixes #1708