Skip to content

Fix confusing swap chain image count calculation #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpx1000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix confusing swap chain image count calculation #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions en/03_Drawing_a_triangle/01_Presentation/01_Swap_chain.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,22 +339,16 @@ minimum number that it requires to function:

[,c++]
----
uint32_t imageCount = surfaceCapabilities.minImageCount;
uint32_t minImageCount = surfaceCapabilities.minImageCount;
----

However, simply sticking to this minimum means that we may sometimes have
to wait on the driver to complete internal operations before we can acquire
another image to render to. Therefore, it is recommended to request at least
one more image than the minimum:

[,c++]
----
uint32_t imageCount = surfaceCapabilities.minImageCount + 1;
----

We should also make sure to not exceed the maximum number of images while
doing this, where `0` is a special value that means that there is no maximum,
resulting in this helper function
another image to render to. In practice, it's common to request a few more
images than the strict minimum to give yourself some headroom - the helper
function below requests at least three images, while also making sure to not
exceed the maximum number of images the implementation supports, where `0` is
a special value that means there is no maximum:

[,c++]
----
Expand Down
Loading