Skip to content

Remove mentions of render passes #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaschaWillems wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −9
Open

Remove mentions of render passes #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ void recreateSwapChain()
}
----

Note that we don't recreate the renderpass here for simplicity.
In theory, it can be possible for the swap chain image format to change during an applications' lifetime, e.g.,
when moving a window from a standard range to a high dynamic range monitor.
This may require the application to recreate the renderpass to make sure the change between dynamic ranges is properly reflected.

We'll move the cleanup code of all objects that are recreated as part of a swap chain refresh from `cleanup` to `cleanupSwapChain`:

[,c++]
Expand Down
2 changes: 1 addition & 1 deletion en/Advanced_glTF/Debugging_Visual_Auditing/02_debug_drawers.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ Rendering colored lines requires a specialized graphics pipeline. Because we wan

[source,cpp]
----
void create_debug_pipeline(VkDevice device, VkRenderPass render_pass, VkPipelineLayout layout, VkPipeline& out_pipeline)
void create_debug_pipeline(VkDevice device, VkPipelineLayout layout, VkPipeline& out_pipeline)
{
// 1. Shaders: Simple unlit color pass
// Vertex shader takes vec3 pos, vec3 color and multiplies by ViewProj.
Expand Down
4 changes: 1 addition & 3 deletions en/Building_a_Simple_Engine/Tooling/02_cicd.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ import vulkan_raii;

// A testable function using vk::raii
bool create_pipeline(vk::raii::Device& device,
vk::raii::RenderPass& render_pass,
vk::raii::PipelineLayout& layout,
vk::raii::Pipeline& out_pipeline) {
try {
Expand All @@ -139,11 +138,10 @@ TEST_CASE("Pipeline creation") {
vk::raii::Context context;
auto instance = create_test_instance(context);
auto device = create_test_device(instance);
auto render_pass = create_test_render_pass(device);
auto layout = create_test_pipeline_layout(device);

vk::raii::Pipeline pipeline{nullptr};
REQUIRE(create_pipeline(device, render_pass, layout, pipeline));
REQUIRE(create_pipeline(device, layout, pipeline));
REQUIRE(pipeline);
}
----
Expand Down
Loading