fix(mobile): open GitLab and Bitbucket review links in-app - #6185
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit c68846a resolves the previously reported GitLab merge-request separator by routing the Review PR subtitle through Files Reviewed (4 files)
Previous Review Summary (commit e5afe6f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e5afe6f)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (17 files)
Notes: verified no other call sites of the removed Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
e5afe6f to
c68846a
Compare
Changelog for users
Changelog for maintainers
parseProviderPrUrlis now the only entry point for review-link recognition; chat links, Code Reviewer, security findings and the share gate stop callingparseGitHubPrUrldirectly.findFirstProviderPrUrlextracts the first provider URL from free text and replaces the deletedfindFirstGitHubPrUrl.resolveCodeReviewerOpenPrDestinationreturns a readyhrefbuilt byproviderPrRoutePath; callers push it directly.getPrReviewPathis removed fromprofile-agent-navigation; every caller usesproviderPrRoutePath.parseGitHubPrUrlstays as the GitHub arm and the shared resolver delegates to it, so GitHub behavior is unchanged.?instance=query parameter.E2E proof
Recording of the verified flow (waits trimmed)
scripted-shard1.mp4.trim.mp4
[e5] Code Reviewer GitLab MR review 'Open pull request' opens in-app review instead of the browser — android emulator-5606: Code Reviewer > Recent reviews lists 'GitLab MR review igor352/kilo-e2e-personal #1' (e5-list.png), the detail screen has 'Open pull request' (e5-detail.png), and tapping it navigates to the in-app GitLab MR review route 'Merge request !1' (e5-dispatch.log) not a browser; the in-app content then shows a retryable 'Could not load merge request' with 'Retry' (e5-content.log) from a pre-existing server BAD_GATEWAY on providerReview.getPullRequest, unrelated to this routing diff; fixture = dev:seed code-reviews:review-list row re-pointed to the GitLab MR URL via db.sh.
[e5] Code Reviewer GitLab MR review 'Open pull request' opens in-app review instead of the browser — android emulator-5606: Code Reviewer > Recent reviews lists 'GitLab MR review igor352/kilo-e2e-personal #1' (e5-list.png), the detail screen has 'Open pull request' (e5-detail.png), and tapping it navigates to the in-app GitLab MR review route 'Merge request !1' (e5-dispatch.log) not a browser; the in-app content then shows a retryable 'Could not load merge request' with 'Retry' (e5-content.log) from a pre-existing server BAD_GATEWAY on providerReview.getPullRequest, unrelated to this routing diff; fixture = dev:seed code-reviews:review-list row re-pointed to the GitLab MR URL via db.sh.
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/autolink-gitlab-bitbucket-mobile-2ef1/e2e-mobile-app/e1-run2.log/home/igor_kilocode_ai/.local/share/kwf/sections/autolink-gitlab-bitbucket-mobile-2ef1/e2e-mobile-app/e1-detail.log/home/igor_kilocode_ai/.local/share/kwf/sections/autolink-gitlab-bitbucket-mobile-2ef1/e2e-mobile-app/e5-run.logOwner request
Follow-ups (not changed here)
Open findings (not fixed here)