(janitor/dependencies) remove unused @next/third-parties dependency from web - #6205
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
…rom web @next/third-parties is no longer referenced anywhere in the codebase. The Google Tag Manager and YouTube embeds it once provided were replaced by custom implementations (src/lib/marketing-tag-scripts.ts and src/components/YouTubeEmbed.tsx). Remove the dependency and its stale dependabot ignore entry.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryVerified the Files Reviewed (3 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies removed
@next/third-parties@16.3.3fromapps/web/package.json(runtimedependencies).third-party-capital@1.0.20(removed automatically from the lockfile).@next/third-partiesentry in.github/dependabot.ymlignore.Evidence each was unused
@next/third-partieshas zero imports, requires, or dynamic imports across the entire monorepo (apps/,services/,packages/,dev/,scripts/,tools/), in every file type (ts,tsx,js,mjs,cjs,json,css).GoogleAnalytics,GoogleTagManager,YouTubeEmbed,GoogleMapsEmbed,GoogleReviews,SchemaMarkup,GTag) anywhere inapps/web/src.apps/web/src(git log -S "from '@next/third-parties'"returns nothing).src/lib/marketing-tag-scripts.ts(buildGoogleTagManagerScript, served viasrc/app/api/marketing-tags/gtm/route.ts) andsrc/components/YouTubeEmbed.tsx.knip(already configured forapps/web) reports@next/third-partiesinUnused dependencies.next.config.mjsonly references@next/mdxand@next/bundle-analyzer; it does not reference@next/third-parties.Dynamic, configuration, and tooling references checked
import()/require()of the package.package.jsonscript (web or root).next.config.mjs,postcss.config.mjs,jest.config.ts,playwright.config.ts,knip.ts, or any other config..github/dependabot.ymlignore rule, which was removed alongside the dependency.pnpm-workspace.yamloverride/catalog entry.Package publication and peer-dependency considerations
apps/webis"private": true— it is not published, so removing a dependency has no published-contract impact.@next/third-partieswas a regular (non-peer) dependency ofapps/web; it is not a peer/optional dependency of any package.apps/webdeclared it).Validation performed
pnpm install --lockfile-onlyregenerated the lockfile; diff is limited to@next/third-parties+third-party-capital(20 deletions, no unrelated changes).tsgo --noEmit(web typecheck): passed (exit 0).oxlint --config .oxlintrc.json apps/web/src:Found 0 warnings and 0 errors.@next/third-partiesin the repo after removal.Uncertainty
jest,playwright) andnext buildwere not run: the sandbox cannot start Postgres/Redis and is memory-constrained. This is low risk because the removed dependency has zero code references, so no test or build path can resolve to it..github/dependabot.ymlstill contains similarly stale "Stay on Next.js v15" ignore rules fornextand@next/mdx(the app is on Next 16.3.3). These are pre-existing and intentionally left out of scope.