refactor(mobile): consolidate the prepareSession repository mapping - #6256
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe previous Files Reviewed (19 files)
Previous Review Summaries (4 snapshots, latest commit b906066)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit b906066)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (20 files)
Fix these issues in Kilo Cloud Previous review (commit 7102fd2)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files changed since the previous review)
Previous review (commit 57b574d)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files changed since the previous review)
Notes
Previous review (commit dd27e56)Status: No Issues Found | Recommendation: Merge Files Reviewed (18 files)
Notes
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
kilo-review — independent audit of the published diff. Status: 1 Issues
|
|
bot: Accepted. Pushed 95b8f40 (kwf What changed:
|
95b8f40 to
57b574d
Compare
7102fd2 to
b906066
Compare
0d2928c to
a886e2a
Compare
Changelog for users
Updating.Couldn't refreshwith Retry, and the rows stay readable.Changelog for maintainers
apps/mobile/src/components/agents/session-list-refresh-status.tsx:52— accepted: under reduced motion the reserved band'sActivityIndicatorduplicated the progress the mounted centered no-match body already draws, so one pull showed two indicators. The band now suppresses its spinner when that body owns the progress.Updatingcopy there, and a Retry still shows the band's spinner because the body draws none.progressInBodyis threaded from the screen's pull state through the live feedback state to the reserved line and defaults to false, so band-only surfaces are unchanged; review thebodyDrawsProgressgate first, because a true value outside an in-flight no-match pull drops the band's only reduced-motion indicator.apps/mobile/src/components/agents/prepare-session-repository.tsis the single home of the prepareSession repository fields, the retry fingerprint, and the field writer; the duplicated copies in both hooks are removed, and a new suite pins the writer and fingerprint while the hook suites keep their per-provider field and branch assertions.setUpstreamBranchonly when the shared writer reports it wrote a field, so a Bitbucket row missing its uuids sends neither the field nor the branch; the clone body still writes exactly one repository field and neverupstreamBranch.fullNametogithubRepo(never aplatform:fullNamekey), GitLab writesgitlabProject, and Bitbucket writesbitbucketRepoonly with both uuids; review the writer's uuids guard and boolean return and the fingerprint's output shape andnullcase.styleandchildrenor the Android list fails to mount.E2E proof
The earlier empty E2E proof for this pull-to-refresh behavior is replaced by the Android reduced-motion capture below and the sanitized scenario logs appended under this heading (collected 2026-09-17). The request asked for Android and iOS; only Android was run, so the iOS scope is skipped and pending verification.
Owner request
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e1-indicators.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e1-reduced-motion.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e1-live-session.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/p5-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e3-indicators.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e3-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-29e9/e2e-mobile-app/e2-run.log