Conversation
Explorer finding: notifications-toggled: Same screen: the Security notes row's description is untranslated English inside the Arabic notifications list. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: notifications-toggled Found on revision: f2181ae Repro: 1. set this state first: fault nextjs down; battery 12 discharging; uimode night; relaunch; fault nextjs up; reviews 3; the device in dark mode 2. open the app on emulator-5554 3. reach notifications-toggled 4. the capture shows the defect named below Observed: Same screen: the Security notes row's description is untranslated English inside the Arabic notifications list. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-notifications-toggled-same-screen-the-security-n-dbd2b42e/notifications-toggled.png
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe unavailable-category rows now render translated catalog copy keyed by category instead of the server's English Files Reviewed (91 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
unavailableReason; it renders catalog copy keyed by category instead.NotificationCategoryCapabilitynow carries onlyavailable.notifications.category.*Unavailablekeys; the English source copy lives inen.json.E2E proof
[e4] ux-check: unavailable Security findings row follows the app language (android) — On android emulator-5554, in the same unavailable-capability state (disabled Security findings switch), switching the app language in-session showed the row's catalog copy in German (e4-de-notifications.txt: 'Aktiviere den Kilo-Sicherheitsagenten für einen Bereich, um Sicherheitsbefunde zu erhalten.') and in Spanish (e4-es-notifications.txt: 'Activa el agente de seguridad de Kilo en un ámbito para recibir hallazgos de seguridad.'), never the server's English prose (English baseline in scripted-e1.log), with no app restart; screenshots e4-de-notifications.png / e4-es-notifications.png for the…
[e4] ux-check: unavailable Security findings row follows the app language (android)
[e1] notifications-toggled Arabic — Security findings row disabled with the Arabic reason, chat row keeps its Arabic subtitle, English sentence absent — android emulator-5554; declared start state restored first ('STATE HIT signed-in-home', e1-state.log); the account's Security Agent config was disabled before the run (db.sh: agent_configs security_scan is_enabled=false, selected_repository_ids=[]) and restored to that seeded shape afterwards; the scene passed — e1-run.log:1 'SCENE e1 OK' — and the same moment's digest carries the Arabic reason 'android.widget.TextView فعّل وكيل أمان Kilo على نطاق للحصول على ملاحظات الأمان. tappable [232,1891][923,1928]' (e1-run.log:31) under 'android.widget.TextView ملاحظات الأمان tappable…
[e1] notifications-toggled Arabic — Security findings row disabled with the Arabic reason, chat row keeps its Arabic subtitle, English sentence absent
[e3] ux-check: Arabic (RTL) Notifications shows the Arabic Security findings reason, no English prose — android emulator-5606; app set to العربية via Profile > Account > Language, signed in as the e2e account with Security findings unavailable; SCENE e3 OK digest (e3-run.log) shows 'android.widget.TextView ملاحظات الأمان' with 'android.widget.TextView فعّل وكيل أمان Kilo على نطاق للحصول على ملاحظات الأمان.', the switch [disabled], and the scripted absent step for the English sentence passed (grep 'Enable Kilo Security Agent' = 0 in e3-run.log); zero UX-DEFECT observed in the digest, screenshots left to the visual reviewer.
[e2] ux-check: With all categories available, every category row keeps its original short subtitle (e.g. — android emulator-5554; the all-categories-available state was created through the product's own Security Agent screen (Personal scope, repo iscekic/wf-fake-test selected → agent_configs security_scan is_enabled=true, selected_repository_ids=[1338954801] at run time, reverted to disabled with no repos afterwards) and the parked replay then passed — e2-run.log:2 'SCENE e2 OK' — with the gated row available on its original subtitle 'android.widget.TextView new findings and SLA reminders tappable [157,1855][848,1892]' (e2-run.log:32) under 'android.widget.TextView Security findings tappable…
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-notifications-toggled-same-screen-the-security-n-dbd2b-362e/e2e-mobile-app/e1-run.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-notifications-toggled-same-screen-the-security-n-dbd2b-362e/e2e-mobile-app/e1-notifications-ar.txt/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-notifications-toggled-same-screen-the-security-n-dbd2b-362e/e2e-mobile-app/e1-state.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-notifications-toggled-same-screen-the-security-n-dbd2b-362e/e2e-mobile-app/e2-run.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-notifications-toggled-same-screen-the-security-n-dbd2b-362e/e2e-mobile-app/scripted-e1.logOwner request
[e6] ux-check: all categories available, every row keeps its original short subtitle — android emulator-5606; 'all categories available' was created through the product's own Security Agent screen (Personal scope, repo iscekic/wf-fake-test) and reverted afterwards (agent_configs security_scan is_enabled=false, selected_repository_ids=[]); SCENE e6 OK digest (e6-run.log) lists every category row with its original subtitle — 'android.widget.TextView new findings and SLA reminders' under 'android.widget.TextView Security findings' with an enabled 'android.widget.Switch Security findings' (no [disabled]), plus 'low organization balance warnings', 'replies in your conversations'…
[e5] ux-check — unavailable row's longer description wraps inside its card, no overlap, switch centered, card grows — android emulator-5604; German catalog copy (de.json:341) at e5-notifications-de.txt line 126 has subtitle bounds [157,1929][848,2003] (two lines) inside card [55,1851][1025,2031] = 180 px vs 143 px for single-line sibling rows, switch [875,1905][997,1976] centre 1940.5 = card centre 1941, subtitle x<=848 vs switch x>=875 (no overlap); pixel appearance of the wrap is the visual reviewer's, capture e5-notifications-de.png.
[e2] notifications-toggled Arabic — Security findings row disabled with the Arabic reason, chat row keeps its Arabic subtitle, English sentence absent — android emulator-5604; SCENE e2 OK. e2-scene5.log line 32 'فعّل وكيل أمان Kilo على نطاق للحصول على ملاحظات الأمان.' (= ar.json:341), line 31 title ملاحظات الأمان, line 17 الردود في محادثاتك; e2-notifications-ar.txt line 127 shows the row's Switch enabled="false" (disabled); grep for 'Enable Kilo|Security findings|Chat messages' in the digest = 0, and the account's agent_configs security_scan row is is_enabled=f (unavailable state), which I did not toggle. Screenshots e2.png / e2-notifications-ar.png for the visual reviewer. Parked step list e2 in e2e-scripts.json was edited (unanchored…
Follow-ups (not changed here)
Open findings (not fixed here)