Keep the VIAME launcher window title - #1921
Merged
Merged
Conversation
BryonLewis
previously approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIAME-launched DIVE windows are renamed to VIAME - DIVE Interface and retain that title when desktop.html loads or updates its title. Standalone launches continue to show DIVE Desktop.
Use the existing
DIVE_VIAME_INSTALL_PATHenvironment variable already set by the Linux and Windows VIAME launch scripts, so no companion launcher change is required.Validation: TypeScript and lint passed; the Electron main/preload/renderer build passed. A real Electron smoke test launched both modes in isolated user-data directories and verified that an HTML title update cannot overwrite the VIAME title.