Make sequence-wide Type Filters a saved user preference - #1924
Closed
mattdawkins wants to merge 2 commits into
Closed
Make sequence-wide Type Filters a saved user preference#1924mattdawkins wants to merge 2 commits into
mattdawkins wants to merge 2 commits into
Conversation
mattdawkins
changed the title
Collaborator
|
This is just renaming and forcing the switch to the opposite default for an existing feature. We have the "Filter by Frame" option in the UI for type settings that will filter the annotations by the current frame. It is off by default but can be toggled on and saved by the user. It also matches our Typer counter systme where we show Total:frame counts. This change renames it and makes it more like a negative opt-in. I.E. Before you "Filter by Frame" to make it show the current frame's types. The update has you turn off "Show types from entire sequence" to simulate the same behavior. I think this is a bit more confusing and not as direct as the existing option. |
Collaborator
|
closed in favor of #1926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type Settings now exposes Show types from entire sequence, enabled by default. It keeps types with zero current-frame annotations in the list; disabling it limits rows to current-frame types. The choice is saved across sequences using the existing frame-filter setting.
Validation: 35 settings, settings-panel, and type-list tests passed; changed-file lint passed.