Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 718cfc4b89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| AKAUNTING_VERSION: ${AKAUNTING_VERSION:-3.2.3} | ||
| volumes: | ||
| - ./volumes/akaunting:/var/www/html | ||
| - ./volumes/akaunting-data:/var/www/akaunting-data |
There was a problem hiding this comment.
When an app is installed through Akaunting's App Store, its runtime files and web assets are written under /var/www/html/modules; the existing .docker/nginx/conf.d/http.conf:47-49 explicitly expects to serve assets from that directory. This replacement volume persists only .env, storage, and bootstrap/cache, so installed modules are lost when the PHP container is recreated and their assets are never visible in the separate Nginx container even before recreation. Mount the modules directory into both services, writable from PHP and readable from Nginx.
Useful? React with 👍 / 👎.
| services: | ||
| akaunting.php: | ||
| build: .docker/php | ||
| image: ghcr.io/librecodecoop/akaunting-docker-php:${AKAUNTING_IMAGE_TAG:-main} |
There was a problem hiding this comment.
When the published main image exists, changing AKAUNTING_VERSION and running the documented docker compose pull/up sequence still runs that prebuilt image, whose workflow fixes Akaunting at 3.2.3; the build argument is used only when a local build actually occurs. This also follows Compose's documented behavior when image and build coexist: it pulls the image first and builds only if it is not found. Consequently, the README's supported version-selection path silently deploys the wrong version unless users explicitly build; either connect the version to the image tag or require an explicit build.
Useful? React with 👍 / 👎.
| fi | ||
| cp .env.example .env | ||
| rm -rf /var/www/html/bootstrap/cache | ||
| ln -s "${AKAUNTING_DATA_DIR}/bootstrap/cache" /var/www/html/bootstrap/cache |
There was a problem hiding this comment.
On an image upgrade, this symlink reuses bootstrap/cache files generated by the previous image's Composer dependency set instead of the package and service manifests built into the new image. Laravel loads those manifests while bootstrapping every request and Artisan command, so a dependency/provider change can make the new container fail before the documented optimize:clear command can repair it. Keep this generated cache writable but image-local, or clear and repopulate it from the new image before booting.
Useful? React with 👍 / 👎.
Signed-off-by: henmohr <henriquemohr@redes.ufsm.br>
vitormattos
left a comment
vitormattos
left a comment
There was a problem hiding this comment.
I think we should simplify this before adding an image build pipeline.
Some application customizations are deployment-specific and should not become part of the public Docker image or this repository. We can keep the Docker setup generic and apply environment-specific customizations separately, for example through Compose overrides or deployment configuration.
First, I think we should validate if the official Akaunting image can be used as our base. Then we can keep only the infrastructure that is actually required here.
2 participants
Summary
Validation