fix: enforce envelope ownership when adding files - #8309
Open
vitormattos wants to merge 8 commits into
Open
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
vitormattos
force-pushed
the
security/envelope-owner-authorization
branch
2 times, most recently
from
September 9, 2026 00:56
953ccf7 to
d2fb25f
Compare
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
security/envelope-owner-authorization
branch
from
September 9, 2026 01:09
c33e50b to
c1f1091
Compare
vitormattos
marked this pull request as ready for review
September 9, 2026 01:10
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces object ownership before adding files to an existing envelope.
RequireManageronly requires an authenticated manager/requester context and does not authorize access to a specific LibreSign file. Theadd-fileendpoint now applies the existing file ownership predicate immediately after resolving the envelope and before upload processing.Regression coverage
tests/php/Api/Controller/FileControllerTest.phpvalidates the cross-owner rejection through the existing ByJG/OpenAPI contract test infrastructure.Security
Related to the private security advisory for cross-owner envelope document injection.