[stable35] chore(deps-dev): upgrade vitest and its coverage provider to 5 - #8312
Merged
Merged
Conversation
chore(deps-dev): upgrade vitest and its coverage provider to 5 Dependabot proposed vitest 5 alone in #8295 and the install failed, because @vitest/coverage-v8 pins the vitest version it supports. The two packages have to move together. Grouping them in the Dependabot configuration keeps future updates in a single pull request, so the pair cannot drift apart again. Vitest 5 reports a pending dynamic import as an unhandled rejection when the module runner closes. The router test asserted that the lazy route loader returns a thenable but never awaited it, so the import outlived the test. Awaiting it keeps what the test checks and also proves the component actually loads. Ref #8299 Assisted-by: Claude Code:claude-opus-5 Signed-off-by: André Maia <andrefnkmm@gmail.com> [skip ci]
vitormattos
approved these changes
Sep 9, 2026
vitormattos
marked this pull request as ready for review
September 9, 2026 14:06
vitormattos
force-pushed
the
backport/8306/stable35
branch
from
September 9, 2026 14:06
bb3df97 to
1c7ff95
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
backport/8306/stable35
branch
from
September 9, 2026 14:07
1c7ff95 to
4943025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8306
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.