refactor(otlp): separate compression type from helpers - #137
Merged
Merged
Conversation
Move OtlpCompression into a focused public type header, retain the historical include path as a compatibility wrapper, and make the OTLP backend call detail compression helpers explicitly. Add include-contract coverage for both public headers.
Keep OtlpCompressionType.hpp as the sole OTLP compression type header. Remove the unused compatibility path and its include-contract test so the public include surface reflects the internal-only status of the old header.
Do not advertise OtlpCompressionType.hpp as a standalone public include. The OTLP compression type remains covered through the supported logger umbrella headers.
Add a Linux C++17 job that configures LOGIT_WITH_OTLP with bundled kurlyk dependencies and runs the OTLP test suite. Keep the PR description aligned with the aggregate-first header contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No production behavior or compression semantics changed; the change only clarifies internal header ownership and verifies the optional OTLP build path.