Skip to content

fix: address latest transport handshake review feedback - #49

Merged
zchuango merged 5 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-round3
Sep 17, 2026
Merged

zchuango merged 5 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-round3

Conversation

@Spicy-cream

@Spicy-cream Spicy-cream commented Sep 17, 2026

Copy link
Copy Markdown

Summary

Address the latest review feedback on PR3535.

Changes

  • Restore the _cq_sid guard before removing an RDMA completion-channel consumer.
  • Return TRY_OTHERS for prefixes that cannot match UBSHM or RDMA handshake magic.
  • Preserve NOT_ENOUGH_DATA for valid fragmented UB, RDMA, and RDM3 prefixes.
  • Fall back to TCP when RDMA or UBSHM endpoint allocation fails instead of failing the socket.
  • Correct UBSHM polling flag descriptions.
  • Restore four-space indentation in the affected transport and endpoint code.
  • Add regression tests for impossible and fragmented handshake magic prefixes.

Validation

  • Build: passed.
  • Common transport handshake tests: 19/19 passed.
  • UBSHM/UBRING tests: 15/15 passed.
  • RDMA tests: 86/86 passed.

This PR targets the source branch used by apache#3535.

@zchuango
zchuango merged commit f3a89d9 into LinQuickDev:transport-handshake Sep 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants