fix: verify 10-bit probe succeeded before advertising - #5690
Open
bitness wants to merge 2 commits into
Open
Conversation
Adds two arrays that store the probe results for h264, hevc, and av1's 10-bit 4:2:0 and 4:4:4 encoding support. The naming scheme for the arrays follows the codebase's use of "dynamic_range" to indicate 10-bit, even though these results can be used for SDR and HDR encoding.
With this change, 8-bit and 10-bit 444 encoder advertisement will correctly reflect the results of the encoder probes. Before it, the code used the probe result for 8-bit 444 encoding to decide whether or not to advertise 10-bit 444 encoding, but not all hardware can do both. (Mostly it seems like older Intel Media Engines and older VA-API versions make up that category.) In those cases, the code would still offer the 10-bit 444 advertisement, but if the client selected it, it wouldn't have worked.
bitness
changed the title
bitness
changed the title
|
Contributor
Author
|
Hmm, SonarQube is displeased with the new variables I added not being |
Member
|
Sunshine has a lot of existing sonar issues. I'll review if these should be fixed or not. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes make Sunshine separately track encoder probe results for 10-bit encoding with 4:2:0 and 4:4:4 chroma subsampling, and verifies that the probes succeeded before advertising support for those configurations. Without these patches, Sunshine conflates a successful 8-bit YUV 4:4:4 encoding probe with the ability to encode 10-bit YUV 4:4:4, which isn't always the case on some hardware or driver/API combinations.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.