fix: missing initializers and incorrect default for native_pen_touch - #5693
Conversation
Bundle ReportBundle size has no change ✅ |
|
Awesome, thanks for this! Looks like it might be different for clang? https://github.com/LizardByte/Sunshine/actions/runs/34655808950/job/103447879614?pr=5693#step:11:4294 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5693 +/- ##
==========================================
+ Coverage 37.53% 37.66% +0.12%
==========================================
Files 102 104 +2
Lines 25478 26094 +616
Branches 11294 11559 +265
==========================================
+ Hits 9562 9827 +265
- Misses 14953 14990 +37
- Partials 963 1277 +314
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
38352d3 to
79ddc5b
Compare
|
It looks like GCC doesn't have an equivalent of Since the actual missing initializer bugs have been in shared code (config.cpp and video.cpp), this should still be enough to catch future issues. |
79ddc5b to
38800a6
Compare
Screenshot ComparisonPR #5693 screenshots vs Matrix:
|
|
Apparently if we use |
38800a6 to
003cc0a
Compare
|
|
|
Okay, I can look into for the future. Don't want to derail this PR for sure. |






















































































Description
We keep forgetting to update
config_twhen we add new config options, which causes bugs like #5520. Fix this and all other missing initializers and enable-Wmissing-field-initializersto stop these issues from getting introduced again in the future.The only behavior change in this PR is adding
key_rightalt_to_key_winwhich fixes #5520. All others are either default initialized already or values that are never read.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.