Skip to content

fix(linux): handle NVENC in builds without CUDA - #5698

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/fallback-when-cuda-missing-from-build
Sep 12, 2026
Merged

fix(linux): handle NVENC in builds without CUDA#5698
ReenigneArcher merged 1 commit into
masterfrom
fix/fallback-when-cuda-missing-from-build

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fixes wlroots failure by selecting RAM capture when CUDA support was not compiled

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 12, 2026
@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.67%. Comparing base (dd7a1f7) to head (e596664).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/wlgrab.cpp 70.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
+ Coverage   37.66%   37.67%   +0.01%     
==========================================
  Files         104      104              
  Lines       26094    26103       +9     
  Branches    11558    11563       +5     
==========================================
+ Hits         9827     9834       +7     
- Misses      14050    14201     +151     
+ Partials     2217     2068     -149     
Flag Coverage Δ
Alpine-aarch64 22.58% <50.00%> (+0.01%) ⬆️
Alpine-x86_64 22.70% <50.00%> (+0.01%) ⬆️
Archlinux 21.29% <60.00%> (+0.01%) ⬆️
FreeBSD-amd64 23.49% <62.50%> (+0.01%) ⬆️
Homebrew-macos-15 37.27% <ø> (ø)
Homebrew-macos-26 37.58% <ø> (+0.01%) ⬆️
Homebrew-ubuntu-24.04 24.59% <80.00%> (+0.01%) ⬆️
Linux-AppImage-aarch64 25.86% <60.00%> (+0.01%) ⬆️
Linux-AppImage-x86_64 26.07% <80.00%> (+0.01%) ⬆️
Windows-AMD64 30.42% <ø> (ø)
Windows-ARM64 25.46% <ø> (ø)
macOS-arm64 30.81% <ø> (ø)
macOS-x86_64 31.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/wayland.h 5.55% <ø> (ø)
src/platform/linux/wlgrab.cpp 2.83% <70.00%> (+2.83%) ⬆️

... and 52 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7a1f7...e596664. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-09-12 20:29:50 UTC
Source Run CI Run #5501
Commit e596664decfa6f5c1eaf617bd207ec0f4f820d97

Screenshot Comparison

PR #5698 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit 2ebaae3 into master Sep 12, 2026
81 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/fallback-when-cuda-missing-from-build branch September 12, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Couldn't scale frame: Invalid argument

1 participant