Skip to content

fix(linux): fall back when display is inaccessible - #189

Open
ReenigneArcher wants to merge 1 commit into
masterfrom
codex/issue-5678
Open

fix(linux): fall back when display is inaccessible#189
ReenigneArcher wants to merge 1 commit into
masterfrom
codex/issue-5678

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Configure Qt with ordered Wayland/X11 platform candidates and retain the minimal plugin as the final fallback. This prevents headless service environments from aborting when display variables point to unreachable endpoints while preserving explicit platform overrides.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Configure Qt with ordered Wayland/X11 platform candidates and retain the minimal plugin as the final fallback. This prevents headless service environments from aborting when display variables point to unreachable endpoints while preserving explicit platform overrides.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.98%. Comparing base (7526f29) to head (cd81304).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/tray_qt.cpp 93.93% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   61.62%   63.98%   +2.35%     
==========================================
  Files           5        5              
  Lines         516      547      +31     
  Branches      194      212      +18     
==========================================
+ Hits          318      350      +32     
+ Misses        131      129       -2     
- Partials       67       68       +1     
Flag Coverage Δ
Linux-qt5 61.61% <93.10%> (+2.87%) ⬆️
Linux-qt6 61.13% <93.10%> (+2.90%) ⬆️
Windows-qt6 57.62% <94.73%> (+1.55%) ⬆️
macOS-qt6 56.43% <73.91%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/tray_qt.cpp 71.77% <93.93%> (+7.38%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7526f29...cd81304. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-09-11 19:14:28 UTC
Source Run CI Run #802
Commit cd813042286152f108dbb57aac6334f62682f4fc

Screenshot Comparison

PR #189 screenshots vs screenshots baseline.

Matrix: Linux-qt5

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Linux-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Windows-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: macOS-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sunshine 2026.906 crashes when launched through Decky Sunshine on Steam Deck

1 participant