Also SoA on root - #4710
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (26)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesAlbum listing API
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: 🔵 Low · up to The PR is mergeable with minor follow-up for avoidable bucket-recomputation load and an inaccurate cache invalidation test fixture. Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
Full details: Docstring CoverageExplanation Docstring coverage is 51.87% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 241 functions across 58 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
app/Http/Controllers/Admin/SettingsController.php (1)
62-62: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winRemove
sorting_albums_orderfromROOT_ALBUM_BUCKET_RECOMPUTE_CONFIGS.
AlbumBucketComputer::compute()uses the sorting column and granularity, not the sort order. An order-only change cannot alterbucket_id, but it can still queue a read and bulk upsert for every root album.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: c24ce167-bc00-4ad6-80bf-b7d5ccdea9f4
📒 Files selected for processing (48)
app/Actions/Albums/Top.phpapp/Contracts/Http/Requests/RequestAttribute.phpapp/Enum/AlbumListingScope.phpapp/Enum/ColumnSortingAlbumType.phpapp/Enum/ColumnSortingType.phpapp/Http/Controllers/Admin/SettingsController.phpapp/Http/Controllers/Gallery/AlbumBucketController.phpapp/Http/Controllers/Gallery/AlbumChildrenDataController.phpapp/Http/Controllers/Gallery/AlbumChildrenRightsController.phpapp/Http/Controllers/Gallery/AlbumListing/AlbumCategoryController.phpapp/Http/Controllers/Gallery/AlbumListing/AlbumChildrenController.phpapp/Http/Controllers/Gallery/AlbumListing/AlbumRootController.phpapp/Http/Requests/Album/GetAlbumCategoryRequest.phpapp/Http/Requests/Album/GetScopedAlbumsRequest.phpapp/Http/Requests/Photo/GetPhotoAssetRequest.phpapp/Http/Resources/V3/AlbumCategoryListResource.phpapp/Http/Resources/V3/AlbumCategoryRightsResource.phpapp/Http/Resources/V3/AlbumChildrenDataResource.phpapp/Http/Resources/V3/AlbumChildrenRightsResource.phpapp/Jobs/RecomputeRootAlbumBucketsJob.phpapp/Services/Cache/CacheKeyProvider.phpdatabase/migrations/2026_09_02_120000_remove_owner_id_album_sorting.phpdocs/specs/3-reference/api-design.mddocs/specs/3-reference/database-schema.mddocs/specs/4-architecture/features/056-api-v3-asset-retrieval/spec.mddocs/specs/4-architecture/features/056-api-v3-asset-retrieval/tasks.mddocs/specs/4-architecture/features/062-root-album-listing-struct-of-arrays/plan.mddocs/specs/4-architecture/features/062-root-album-listing-struct-of-arrays/spec.mddocs/specs/4-architecture/features/062-root-album-listing-struct-of-arrays/tasks.mddocs/specs/4-architecture/knowledge-map.mddocs/specs/4-architecture/open-questions.mddocs/specs/4-architecture/roadmap.mdresources/js/lychee.d.tsresources/js/v7/views/gallery-panels/Search.vueresources/js/v8/views/gallery-panels/Search.vueroutes/api_v3.phptests/Feature_v2/Settings/OwnerIdSortingMigrationTest.phptests/Feature_v2/Settings/UpdateSettingsTest.phptests/Feature_v3/Album/AlbumBucketsV3Test.phptests/Feature_v3/Album/AlbumCategoryV3Test.phptests/Feature_v3/Album/AlbumChildrenDataV3Test.phptests/Feature_v3/Album/AlbumChildrenRightsV3Test.phptests/Feature_v3/Album/AlbumRootV3Test.phptests/Feature_v3/Photo/PhotoAssetV3Test.phptests/Precomputing/CoverSelection/RecomputeAlbumBucketsCommandTest.phptests/Precomputing/CoverSelection/RecomputeRootAlbumBucketsJobTest.phptests/Unit/Listeners/ManagedCacheAlbumListingInvalidatorTest.phptests/Unit/Services/Cache/CacheKeyProviderTest.php
💤 Files with no reviewable changes (3)
- app/Http/Controllers/Gallery/AlbumChildrenRightsController.php
- app/Http/Controllers/Gallery/AlbumBucketController.php
- app/Http/Controllers/Gallery/AlbumChildrenDataController.php
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.
…t-album-approach-tags-owners-root
…t-album-approach-tags-owners-root
…t-album-approach-tags-owners-root
…t-album-approach-tags-owners-root
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
tests/Unit/Listeners/ManagedCacheAlbumListingInvalidatorTest.php (1)
440-440: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUse the production tag set in this cache test.
rootAlbumBucketsKey(...)is used byAlbumRootController::buckets(), which addsalbumListingGlobalTag()atapp/Http/Controllers/Gallery/AlbumListing/AlbumRootController.phpLine 256. This fixture omits that tag, soassertNotEvicted()tests a cache entry that production does not create. Add the global tag and assert eviction, or use a clearly synthetic key for the narrower tag-behavior test.docs/specs/2-how-to/admin-dashboard.md (1)
58-58: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winMaintain the required documentation footer in every edited Markdown file.
The edited files do not all contain a current
Last updatedfooter.
docs/specs/2-how-to/admin-dashboard.md#L58-L58: change the date from2026-04-22to2026-09-03.docs/specs/2-how-to/customize-v8-nuxt-ui.md#L88-L88: append---and*Last updated: 2026-09-03*.docs/specs/3-reference/managed-cache-service.md#L240-L240: append---and*Last updated: 2026-09-03*.As per coding guidelines, documentation files must end with an hr line followed by
*Last updated: [date of the update]*.Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 8ec903cb-c8db-4ed6-b225-95c8fa9798c9
📒 Files selected for processing (12)
app/Http/Controllers/Gallery/AlbumListing/AlbumRootController.phpapp/Jobs/RecomputeRootAlbumBucketsJob.phpdocs/specs/2-how-to/admin-dashboard.mddocs/specs/2-how-to/customize-v8-nuxt-ui.mddocs/specs/3-reference/api-design.mddocs/specs/3-reference/database-schema.mddocs/specs/3-reference/image-processing.mddocs/specs/3-reference/managed-cache-service.mdroutes/api_v2.phproutes/api_v3.phptests/Feature_v3/Album/AlbumRootV3Test.phptests/Unit/Listeners/ManagedCacheAlbumListingInvalidatorTest.php
🚧 Files skipped from review as they are similar to previous changes (5)
- docs/specs/3-reference/database-schema.md
- tests/Feature_v3/Album/AlbumRootV3Test.php
- docs/specs/3-reference/api-design.md
- routes/api_v3.php
- app/Jobs/RecomputeRootAlbumBucketsJob.php
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit
New Features
Improvements
Breaking Changes
/childrenalbum endpoints with consolidated routes.