Added Comfy Kitchen Attention launch option - #1738
Open
e-nord wants to merge 3 commits into
Open
Conversation
Runs csharpier/xamlstyler on LaunchOption.cs, LaunchOptionCard.cs, and LaunchOptionsDialog.axaml, which had drifted from the current formatter style. Isolated here so the following behavioral commit has a clean, reviewable diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds ComfyUI's Composable Kernel attention backend as a selectable Cross Attention Method option, for both ComfyUI and ComfyUI-Zluda. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Cross Attention Method flags are mutually exclusive in ComfyUI's argparse, but the launch options UI rendered every Bool-type option as an independent checkbox, so multiple could be selected at once and ComfyUI would refuse to start (e.g. --use-ck-attention not allowed with --use-sage-attention). LaunchOptionDefinition already had an unused MaxSelectedOptions field; setting it to 1 on a definition now renders its options as a radio group instead of checkboxes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Comfy Kitchen Attention to the ComfyUI cross-attention launch options and fixing the (likely intended but missing) mutual exclusivity of those options.