fix(engine): resolve f-string syntax error in trainer.py and add MPS support - #25
Open
atharvasardarx wants to merge 1 commit into
Open
fix(engine): resolve f-string syntax error in trainer.py and add MPS support#25atharvasardarx wants to merge 1 commit into
atharvasardarx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves an import blocking SyntaxError in trainer.py caused by invalid nested double quotes within an f-string strftime() evaluation. Resolving this syntax bug unblocks custom module imports across the repository, allowing demo notebooks and model training workflows to execute as expected.
In addition to the engine fix, the default device allocation in 01_LorentzParT_demo.ipynb has been updated to evaluate torch.backends.mps.is_available(), enabling native Apple Silicon GPU acceleration alongside standard CUDA and CPU fallbacks.
All modified files have been verified locally to confirm that module imports execute cleanly without syntax errors and notebook cells run smoothly on MPS enabled environments.